Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/884#discussion_r47459279
  
    --- Diff: 
tajo-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
 ---
    @@ -447,22 +499,35 @@ public void channelRegistered(ChannelHandlerContext 
ctx) throws Exception {
         public void channelRead0(ChannelHandlerContext ctx, FullHttpRequest 
request)
                 throws Exception {
     
    -      if (request.getMethod() != HttpMethod.GET) {
    -        sendError(ctx, HttpResponseStatus.METHOD_NOT_ALLOWED);
    +      if (request.getDecoderResult().isFailure()) {
    +        LOG.error("Http decoding failed. ", 
request.getDecoderResult().cause());
    +        sendError(ctx, request.getDecoderResult().toString(), 
HttpResponseStatus.BAD_REQUEST);
             return;
           }
     
    -      ProcessingStatus processingStatus = new 
ProcessingStatus(request.getUri().toString());
    -      processingStatusMap.put(request.getUri().toString(), 
processingStatus);
    +      if (request.getMethod() == HttpMethod.DELETE) {
    +        HttpResponse response = new 
DefaultHttpResponse(HttpVersion.HTTP_1_1, HttpResponseStatus.NO_CONTENT);
    +        
ctx.writeAndFlush(response).addListener(ChannelFutureListener.CLOSE);
    +
    +        clearIndexCache(request.getUri());
    --- End diff --
    
    You should add return state
    ```
    2015-12-14 12:33:27,993 ERROR: 
org.apache.tajo.pullserver.TajoPullServerService (channelRead0(523)) - Failed 
to decode uri eb_1450063997899_0015_000001
    2015-12-14 12:33:27,995 ERROR: 
org.apache.tajo.pullserver.TajoPullServerService (channelRead0(523)) - Failed 
to decode uri eb_1450063997899_0015_000004
    2015-12-14 12:33:27,999 ERROR: 
org.apache.tajo.pullserver.TajoPullServerService (channelRead0(523)) - Failed 
to decode uri eb_1450063997899_0015_000003
    2015-12-14 12:33:28,059 ERROR: 
org.apache.tajo.pullserver.TajoPullServerService (channelRead0(523)) - Failed 
to decode uri eb_1450063997899_0015_000008
    2015-12-14 12:33:28,060 ERROR: 
org.apache.tajo.pullserver.TajoPullServerService (channelRead0(523)) - Failed 
to decode uri eb_1450063997899_0015_000007
    2015-12-14 12:33:28,074 ERROR: 
org.apache.tajo.pullserver.TajoPullServerService (channelRead0(523)) - Failed 
to decode uri eb_1450063997899_0015_000002
    2015-12-14 12:33:28,111 ERROR: 
org.apache.tajo.pullserver.TajoPullServerService (channelRead0(523)) - Failed 
to decode uri eb_1450063997899_0015_000009
    2015-12-14 12:33:28,158 ERROR: 
org.apache.tajo.pullserver.TajoPullServerService (channelRead0(523)) - Failed 
to decode uri eb_1450063997899_0015_000011
    2015-12-14 12:33:28,181 ERROR: 
org.apache.tajo.pullserver.TajoPullServerService (channelRead0(523)) - Failed 
to decode uri eb_1450063997899_0015_000012
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to