Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/880#discussion_r47464263
--- Diff:
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java
---
@@ -702,25 +705,22 @@ public String toString() {
@Nullable EvalNode
filterCondition)
throws IOException, MissingTablePropertyException,
InvalidTablePropertyException {
- List<IndexPredication> indexPredications = new ArrayList<>();
- Column[] indexableColumns = getIndexableColumns(tableDesc);
- if (indexableColumns != null && indexableColumns.length == 1) {
- // Currently supports only single index column.
- List<Set<EvalNode>> indexablePredicateList =
findIndexablePredicateSet(filterCondition, indexableColumns);
- for (Set<EvalNode> eachEvalSet: indexablePredicateList) {
- Pair<Datum, Datum> indexPredicationValues =
getIndexablePredicateValue(columnMapping, eachEvalSet);
- if (indexPredicationValues != null) {
- IndexPredication indexPredication = new IndexPredication();
- indexPredication.setColumn(indexableColumns[0]);
-
indexPredication.setColumnId(tableDesc.getLogicalSchema().getColumnId(indexableColumns[0].getQualifiedName()));
-
indexPredication.setStartValue(indexPredicationValues.getFirst());
-
indexPredication.setStopValue(indexPredicationValues.getSecond());
-
- indexPredications.add(indexPredication);
- }
- }
+ final Column[] indexableColumns = getIndexableColumns(tableDesc);
+ if (indexableColumns == null && indexableColumns.length == 0) {
--- End diff --
Thank you for the comment. I'll fix it and then commit it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
