Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/883#discussion_r47589038
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/function/FunctionLoader.java ---
@@ -299,4 +284,38 @@ private static StaticMethodInvocationDesc
extractStaticMethodInvocation(Method m
return sqlFuncs;
}
+
+ public static Collection<FunctionDesc> loadFunctions(TajoConf conf)
throws IOException, AmbiguousFunctionException {
+ List<FunctionDesc> functionList = new
ArrayList<>(loadBuiltinFunctions().values());
+ List<FunctionDesc> udfs = loadUserDefinedFunctions(conf);
+
+ return mergeFunctionLists(functionList, udfs);
+ }
+
+ @SafeVarargs
+ static Collection<FunctionDesc> mergeFunctionLists(List<FunctionDesc>
... functionLists)
+ throws AmbiguousFunctionException {
+
+ Map<Integer, FunctionDesc> funcMap = new HashMap<>();
+ List<FunctionDesc> baseFuncList = functionLists[0];
+
+ // Build a map with a first list
+ for (FunctionDesc desc: baseFuncList) {
+ funcMap.put(desc.hashCodeWithoutType(), desc);
+ }
+
+ // Check duplicates for other function lists(should be UDFs
practically)
+ for (int i=1; i<functionLists.length; i++) {
+ for (FunctionDesc desc: functionLists[i]) {
+ if (funcMap.containsKey(desc.hashCodeWithoutType())) {
--- End diff --
Good suggestion! I fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
