[ 
https://issues.apache.org/jira/browse/TAJO-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15057322#comment-15057322
 ] 

ASF GitHub Bot commented on TAJO-2021:
--------------------------------------

Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/911#discussion_r47595720
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java ---
    @@ -242,27 +210,10 @@ private void initWorkerMetrics() {
         workerSystemMetrics = new TajoSystemMetrics(systemConf, Node.class, 
workerContext.getWorkerName());
         workerSystemMetrics.start();
     
    -    workerSystemMetrics.register(Node.QueryMaster.RUNNING_QM, new 
Gauge<Integer>() {
    -      @Override
    -      public Integer getValue() {
    -        if(queryMasterManagerService != null) {
    -          return 
queryMasterManagerService.getQueryMaster().getQueryMasterTasks().size();
    -        } else {
    -          return 0;
    -        }
    -      }
    -    });
    -
    -    workerSystemMetrics.register(Node.Tasks.RUNNING_TASKS, new 
Gauge<Integer>() {
    -      @Override
    -      public Integer getValue() {
    -        if(taskExecutor != null) {
    -          return taskExecutor.getRunningTasks();
    -        } else {
    -          return 0;
    -        }
    -      }
    -    });
    +    workerSystemMetrics.register(Node.QueryMaster.RUNNING_QM, () ->
    +        queryMasterManagerService != null ? 
queryMasterManagerService.getQueryMaster().getQueryMasterTasks().size() : 0);
    --- End diff --
    
    This line is over 120 char
    https://cwiki.apache.org/confluence/display/TAJO/Code+Style


> Some refactoring and changing anonymous class to lambda expression
> ------------------------------------------------------------------
>
>                 Key: TAJO-2021
>                 URL: https://issues.apache.org/jira/browse/TAJO-2021
>             Project: Tajo
>          Issue Type: Task
>          Components: Worker
>    Affects Versions: 0.11.0
>            Reporter: Jongyoung Park
>            Assignee: Jongyoung Park
>            Priority: Trivial
>             Fix For: 0.11.1
>
>
> Some instance variables are moved into local variables.
> And a few anonymous classes are changed to lambda expressions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to