Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/900#issuecomment-164696159
@hyunsik thanks for your work. Even though this patch contains lots of
changes, the code change is very minor. These changes look good.
In addition, changes in tests also look good. Honestly, I think we can do
more realistic query plan tests on TPC-H tables.
The only thing I'm concerned with is that some tests are intended to test
broadcast join, but are not actually executed with broadcast join. I think we
need to change the test query. Do you have any good idea?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---