[
https://issues.apache.org/jira/browse/TAJO-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085282#comment-15085282
]
ASF GitHub Bot commented on TAJO-2032:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/922#discussion_r48939447
--- Diff: tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java ---
@@ -140,7 +140,7 @@ public static int setDateOrder(int dateOrder) {
TAJO_MASTER_INFO_ADDRESS("tajo.master.info-http.address",
"0.0.0.0:26080", Validators.networkAddr()),
// Tajo Rest Service
- REST_SERVICE_PORT("tajo.rest.service.port", 26880),
+ REST_SERVICE_ADDRESS("tajo.rest.service-http.address",
"0.0.0.0:26880", Validators.networkAddr()),
--- End diff --
IMO, ```tajo.rest.service-http.address``` seems to have a duplicate meaning
because rest service is mostly based on http. How about
```tajo.rest.service.address```?
> Change tajo.rest.service.port to be the general style in TAJO.
> --------------------------------------------------------------
>
> Key: TAJO-2032
> URL: https://issues.apache.org/jira/browse/TAJO-2032
> Project: Tajo
> Issue Type: Improvement
> Components: REST API
> Affects Versions: 0.11.1
> Reporter: Byunghwa Yun
> Assignee: Byunghwa Yun
> Priority: Minor
>
> Change the variable name to tajo.rest.service-http.address from
> tajo.rest.service.port, and will set the default value to 0.0.0.0:26880.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
