[
https://issues.apache.org/jira/browse/TAJO-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088818#comment-15088818
]
ASF GitHub Bot commented on TAJO-1921:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/918#issuecomment-169914203
The patch looks good to me. Here are some comments.
Our coding standard uses 2 space instead of tab. Some lines do not follow
the indent of our coding standard. Please refer to
https://cwiki.apache.org/confluence/display/TAJO/Code+Style.
Other parts looks good to me. Here is my +1. Could you correct line
indents? Then, I'll commit it soon.
> Hbase Storage can cause NPE when the hbase cluster is restarted
> ---------------------------------------------------------------
>
> Key: TAJO-1921
> URL: https://issues.apache.org/jira/browse/TAJO-1921
> Project: Tajo
> Issue Type: Bug
> Components: HBase Storage
> Reporter: Hyunsik Choi
> Assignee: Byunghwa Yun
> Fix For: 0.12.0, 0.11.1
>
>
> See the title. The stacktrace is as follow:
> {noformat}
> 2015-10-10 01:16:58,577 ERROR org.apache.tajo.querymaster.Stage: Stage
> (eb_1444397501528_0096_000001) ERROR:
> java.lang.NullPointerException
> at
> org.apache.tajo.storage.hbase.HBaseTablespace.getSplits(HBaseTablespace.java:529)
> at
> org.apache.tajo.querymaster.Stage$InitAndRequestContainer.scheduleFragmentsForLeafQuery(Stage.java:1147)
> at
> org.apache.tajo.querymaster.Stage$InitAndRequestContainer.schedule(Stage.java:1039)
> at
> org.apache.tajo.querymaster.Stage$InitAndRequestContainer.access$800(Stage.java:821)
> at
> org.apache.tajo.querymaster.Stage$InitAndRequestContainer$1.run(Stage.java:847)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
