[
https://issues.apache.org/jira/browse/TAJO-2059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101697#comment-15101697
]
ASF GitHub Bot commented on TAJO-2059:
--------------------------------------
GitHub user eminency opened a pull request:
https://github.com/apache/tajo/pull/945
TAJO-2059: Binary search in BST reader does compare too frequently
Some simple test based on unit test was done with 1M tuples and searching
1M times.
Two columns, which are long and double, are used as sort key.
Count above is a number of invoking compare().
##### Current
find : 44 sec
count : 42001207
##### Patch
find : 43 sec
count : 20141495
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eminency/tajo bstidx
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/945.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #945
----
commit d5fdf2f0e658928ac156d83ec4d4dbfb7f1c42e5
Author: Jongyoung Park <[email protected]>
Date: 2016-01-13T07:33:08Z
lightweight improvement
commit a7b2686f1275e05866dc4d5563a8e0a224fb49e1
Author: Jongyoung Park <[email protected]>
Date: 2016-01-13T09:22:25Z
Refine binary search
commit 58a59e832a8bba350814ab92ef421ae95f5be158
Author: Jongyoung Park <[email protected]>
Date: 2016-01-15T07:39:56Z
test code
commit 74c857dcab827b662d565e13284f665723eb798c
Author: Jongyoung Park <[email protected]>
Date: 2016-01-15T12:05:10Z
Revert "test code"
This reverts commit 58a59e832a8bba350814ab92ef421ae95f5be158.
----
> Binary search in BST reader does compare too frequently
> -------------------------------------------------------
>
> Key: TAJO-2059
> URL: https://issues.apache.org/jira/browse/TAJO-2059
> Project: Tajo
> Issue Type: Improvement
> Components: Storage
> Affects Versions: 0.11.0
> Reporter: Jongyoung Park
> Assignee: Jongyoung Park
>
> Current binary search logic do comparing twice each iteration.
> It should be refined.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
