Github user eminency commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/896#discussion_r49962595
  
    --- Diff: tajo-docs/src/main/sphinx/partitioning/column_partitioning.rst ---
    @@ -11,22 +11,50 @@ How to Create a Column Partitioned Table
     You can create a partitioned table by using the ``PARTITION BY`` clause. 
For a column partitioned table, you should use
     the ``PARTITION BY COLUMN`` clause with partition keys.
     
    -For example, assume there is a table ``orders`` composed of the following 
schema. ::
    +For example, assume a table with the following schema.
     
    -  id          INT,
    -  item_name   TEXT,
    -  price       FLOAT
    +.. code-block:: sql
    +
    +  id        INT,
    +  name      TEXT,
    +  gender    char(1),
    +  grade     TEXT,
    +  country   TEXT,
    +  city      TEXT,
    +  phone     TEXT
    +  );
     
    -Also, assume that you want to use ``order_date TEXT`` and ``ship_date 
TEXT`` as the partition keys.
    -Then, you should create a table as follows:
    +If you want to make country as partitioned column, your Tajo definition 
would be this:
     
     .. code-block:: sql
     
    -  CREATE TABLE orders (
    -    id INT,
    -    item_name TEXT,
    -    price
    -  ) PARTITION BY COLUMN (order_date TEXT, ship_date TEXT);
    +  CREATE TABLE student (
    +    id        INT,
    +    name      TEXT,
    +    gender    char(1),
    +    grade     TEXT,
    +    city      TEXT,
    +    phone     TEXT
    +  ) PARTITION BY COLUMN (country TEXT);
    +
    +Now your users will still query on ``WHERE country = '...'`` but the 2nd 
column will be the original values.
    --- End diff --
    
    1. Using 'can' looks better instead of 'will'.
    2. I think the meaning of "but the 2nd column will be the original values." 
is not so clear.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to