Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/944#discussion_r50217032
--- Diff:
tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java ---
@@ -419,9 +420,7 @@ public Object clone() throws CloneNotSupportedException
{
hash.quantity = quantity;
if (specifiers != null) {
hash.specifiers = new ArrayList<>();
- for (PartitionSpecifier specifier : specifiers) {
- hash.specifiers.add(specifier);
- }
+
hash.specifiers.addAll(specifiers.stream().collect(Collectors.toList()));
--- End diff --
Actually in a case like this, I think it's sufficient and more clear.
```java
hash.specifiers.addAll(specifiers);
```
or more simply,
```java
hash.specifiers = new ArrayList<>(specifiers);
```
Anyway, I think stream doesn't matter.
Because it is simple shallow copy, there are many ways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
