[ 
https://issues.apache.org/jira/browse/TAJO-2048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109692#comment-15109692
 ] 

ASF GitHub Bot commented on TAJO-2048:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/936#discussion_r50335860
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java ---
    @@ -505,6 +503,11 @@ public GetQueryStatusResponse 
getQueryStatus(RpcController controller, GetQueryS
                   builder.setFinishTime(queryInfo.getFinishTime());
                 } else {
                   builder.setFinishTime(System.currentTimeMillis());
    +
    +              if(!StringUtils.isEmpty(queryInfo.getLastMessage())) {
    +                builder.setErrorMessage(queryInfo.getLastMessage());
    +              }
    +              builder.setState(OK);
    --- End diff --
    
    It seems duplicate code to set the query state.


> QueryMaster and TajoWorker should support the exception propagation
> -------------------------------------------------------------------
>
>                 Key: TAJO-2048
>                 URL: https://issues.apache.org/jira/browse/TAJO-2048
>             Project: Tajo
>          Issue Type: Improvement
>          Components: QueryMaster, Worker
>    Affects Versions: 0.11.0
>            Reporter: Jinho Kim
>            Assignee: Jinho Kim
>             Fix For: 0.12.0, 0.11.1
>
>
> Error propagation system was refactored by TAJO-1625. But worker and query 
> master is missing in TAJO-1625. 
> This issue improve error propagation system in TajoWorker and QueryMaster



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to