[ 
https://issues.apache.org/jira/browse/TAJO-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120881#comment-15120881
 ] 

ASF GitHub Bot commented on TAJO-2052:
--------------------------------------

Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/937#discussion_r51085103
  
    --- Diff: 
tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/thirdparty/orc/HdfsOrcDataSource.java
 ---
    @@ -114,9 +117,9 @@ public void readFully(long position, byte[] buffer, int 
bufferOffset, int buffer
           buffers.put(mergedRange, buffer);
         }
     
    -    ImmutableMap.Builder<K, Slice> slices = ImmutableMap.builder();
    +    ImmutableMap.Builder<K, FixedLengthSliceInput> slices = 
ImmutableMap.builder();
         for (Entry<K, DiskRange> entry : diskRanges.entrySet()) {
    --- End diff --
    
    If you use lambda expression, following codes would be simple.


> Upgrading ORC reader version
> ----------------------------
>
>                 Key: TAJO-2052
>                 URL: https://issues.apache.org/jira/browse/TAJO-2052
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Storage
>    Affects Versions: 0.11.0
>            Reporter: Jongyoung Park
>            Assignee: Jongyoung Park
>            Priority: Minor
>
> Currently Tajo uses presto-orc-0.86, but it was old version even when it was 
> integrated because Presto was using JDK 1.8 at that time.
> Now that Tajo is based on JDK 1.8, it can be upgraded to a recent version 
> 0.132.
> It becomes more robust and some minor features are added.
> Additionally hive compatibility is improved, so upgrading is necessary to 
> support Hive-catalog.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to