[ 
https://issues.apache.org/jira/browse/TAJO-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148056#comment-15148056
 ] 

ASF GitHub Bot commented on TAJO-2033:
--------------------------------------

Github user dkhwangbo commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/924#discussion_r52966518
  
    --- Diff: 
tajo-cli/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java
 ---
    @@ -206,4 +278,33 @@ public static String parseErrorMessage(String message) 
{
     
         return message;
       }
    +
    +  /**
    +   * borrowed from Presto
    +   */
    +  private static boolean detectRealTerminal()
    --- End diff --
    
    Oh, I see. When I borrowed this method, I wondered about fitness of this 
comments to tajo. Currently, This comments are written for Presto, not Tajo. So 
I just confused about this comments to include this PR. But, After Testing this 
PR in many individual environment, I take conviction about this method, but I 
missed to include its comments. This is my mistake. I'll add comments. 


> Printing out query status with progress bar in TSQL
> ---------------------------------------------------
>
>                 Key: TAJO-2033
>                 URL: https://issues.apache.org/jira/browse/TAJO-2033
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Dongkyu Hwangbo
>            Assignee: Dongkyu Hwangbo
>            Priority: Minor
>              Labels: cli
>
> Currently, TSQL print out query running progress and query running time 
> line-by-line. To improve this UI, I adopt simple progress bar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to