Github user eminency commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/944#discussion_r56449935
  
    --- Diff: 
tajo-core-tests/src/test/java/org/apache/tajo/client/TestTajoClient.java ---
    @@ -175,10 +176,8 @@ public final void testSessionVariables() throws 
IOException, TajoException, Inte
         String prefixName = "key_";
         String prefixValue = "val_";
     
    -    List<String> unsetList = new ArrayList<>();
    -    for(Map.Entry<String, String> entry: 
client.getAllSessionVariables().entrySet()) {
    -      unsetList.add(entry.getKey());
    -    }
    +    List<String> unsetList = 
client.getAllSessionVariables().entrySet().stream()
    +      .map(Map.Entry<String, String>::getKey).collect(Collectors.toList());
    --- End diff --
    
    I think next one is more readable:
    
    ```java
     List<String> unsetList = new 
ArrayList<>(client.getAllSessionVariables().keySet());
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to