[
https://issues.apache.org/jira/browse/TAJO-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213940#comment-15213940
]
ASF GitHub Bot commented on TAJO-2104:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/988#discussion_r57553017
--- Diff:
tajo-common/src/main/java/org/apache/tajo/schema/QualifiedIdentifier.java ---
@@ -0,0 +1,58 @@
+/*
+ * Lisensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.tajo.schema;
+
+import com.google.common.base.Function;
+import com.google.common.collect.ImmutableList;
+import org.apache.tajo.util.StringUtils;
+
+import javax.annotation.Nullable;
+import java.util.Collection;
+import java.util.List;
+
+import static org.apache.tajo.schema.IdentifierPolicy.DefaultPolicy;
+
+public class QualifiedIdentifier {
+ private List<Identifier> names;
+
+ private QualifiedIdentifier(ImmutableList<Identifier> names) {
+ this.names = names;
+ }
+
+ public String displayString(final IdentifierPolicy policy) {
+ return StringUtils.join(names, ".", new Function<Identifier, String>()
{
--- End diff --
Looks to be IdentifierPolicy.getIdentifierSeperator() instead of ```"."```.
> Implement Identifier which supports quotation information
> ---------------------------------------------------------
>
> Key: TAJO-2104
> URL: https://issues.apache.org/jira/browse/TAJO-2104
> Project: Tajo
> Issue Type: Improvement
> Components: Catalog
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Priority: Minor
> Fix For: 0.12.0
>
>
> We use a plain text to deal with identifiers. It has some limitation which
> loses quotation information. It finally restricts our query federation
> features to support other various systems which have different identifier
> policies. This implementation proposes the new identifier implementation
> which keep quotation flag.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
