[ 
https://issues.apache.org/jira/browse/TAJO-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251535#comment-15251535
 ] 

ASF GitHub Bot commented on TAJO-2122:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/1001#discussion_r60541663
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/worker/TaskImpl.java ---
    @@ -696,44 +696,48 @@ private synchronized void 
fetcherFinished(TaskAttemptContext ctx) {
     
               WorkerConnectionInfo conn = 
executionBlockContext.getWorkerContext().getConnectionInfo();
               if (NetUtils.isLocalAddress(address) && conn.getPullServerPort() 
== uri.getPort()) {
    -
    -            List<FileChunk> localChunkCandidates = 
getLocalStoredFileChunk(uri, systemConf);
    -
    -            for (FileChunk localChunk : localChunkCandidates) {
    -              // When a range request is out of range, storeChunk will be 
NULL. This case is normal state.
    -              // So, we should skip and don't need to create storeChunk.
    -              if (localChunk == null || localChunk.length() == 0) {
    -                continue;
    -              }
    -
    -              if (localChunk.getFile() != null && localChunk.startOffset() 
> -1) {
    -                localChunk.setFromRemote(false);
    -                localStoreChunkCount++;
    -              } else {
    -                localChunk = new FileChunk(defaultStoreFile, 0, -1);
    -                localChunk.setFromRemote(true);
    -              }
    -              localChunk.setEbId(f.getName());
    -              storeChunkList.add(localChunk);
    -            }
    +            localStoreChunkCount++;
    +            runnerList.add(new LocalFetcher(systemConf, uri, 
executionBlockContext, f.getName()));
    +
    +//            List<FileChunk> localChunkCandidates = 
getLocalStoredFileChunk(uri, systemConf);
    --- End diff --
    
    This code is not used anymore. I forgot to remove it.


> PullServer as an Auxiliary service of Yarn
> ------------------------------------------
>
>                 Key: TAJO-2122
>                 URL: https://issues.apache.org/jira/browse/TAJO-2122
>             Project: Tajo
>          Issue Type: New Feature
>          Components: Pull Server
>            Reporter: Jihoon Son
>            Assignee: Jihoon Son
>             Fix For: 0.12.0
>
>
> We are going to support Yarn as Tajo's one of resource schedulers. To do so, 
> the PullServer should be capable of executing as an Auxiliary service.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to