[ 
https://issues.apache.org/jira/browse/TAJO-2127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253570#comment-15253570
 ] 

ASF GitHub Bot commented on TAJO-2127:
--------------------------------------

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/1005#discussion_r60709565
  
    --- Diff: 
tajo-core-tests/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java
 ---
    @@ -565,7 +565,7 @@ public void testImplicitCastForInt8() throws 
TajoException {
       public void testImplicitCastForFloat4() throws TajoException {
         Schema schema = TestSchema1;
     
    -    testEval(schema, "table1", "0,1,2,3,4.1,5.1,6,7", "select col4 + col0 
from table1;", new String [] {"4.1"});
    +    /*testEval(schema, "table1", "0,1,2,3,4.1,5.1,6,7", "select col4 + 
col0 from table1;", new String [] {"4.1"});
    --- End diff --
    
    I forget to remove the comments after some bug fixes.


> Use Type instead of DataType for EvalNode
> -----------------------------------------
>
>                 Key: TAJO-2127
>                 URL: https://issues.apache.org/jira/browse/TAJO-2127
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.12.0
>
>
> See TAJO-2042 and TAJO-2043. This issue will change the return type of 
> EvalNode::getValueType() to be org.apache.tajo.type.Type and its related 
> code. Also, I'll some converter to order to keep existing APIs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to