Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1016#discussion_r63121233
--- Diff:
tajo-algebra/src/main/java/org/apache/tajo/algebra/DataTypeExpr.java ---
@@ -59,15 +68,34 @@ public String getTypeName() {
}
public boolean isPrimitiveType() {
- return !this.isRecordType() && !isMapType();
+ return !isArrayType()&& !isRecordType() && !isMapType();
+ }
+
+ public boolean isArrayType() {
+ return arrayType != null;
}
public boolean isRecordType() {
- return this.typeName.equals(Type.RECORD.name());
+ return recordType != null;
--- End diff --
Will this method be frequently called? It seems not, and I think it would
be better to check the type name because we can figure out when the type is
record but ```recordType``` is null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
