[
https://issues.apache.org/jira/browse/TAJO-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287648#comment-15287648
]
ASF GitHub Bot commented on TAJO-2146:
--------------------------------------
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1015#discussion_r63609934
--- Diff:
tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/fragment/FragmentSerdeHelper.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.tajo.storage.fragment;
+
+import com.google.protobuf.Message;
+import com.google.protobuf.GeneratedMessage.Builder;
+
+/**
+ * FragmentSerdeHelper abstracts how a fragment is serialized /
deserialized to / from a Protocol Buffer message.
+ *
+ * @param <F> Fragment class
+ * @param <P> Protocol Buffer Message class corresponding to the Fragment
class
+ */
+public interface FragmentSerdeHelper<F extends Fragment, P extends
Message> {
--- End diff --
IMO, FragmentSerde seems to be a more proper name. As far as I know, Helper
is mostly used for a utility class.
> Fragment interface cleanup
> --------------------------
>
> Key: TAJO-2146
> URL: https://issues.apache.org/jira/browse/TAJO-2146
> Project: Tajo
> Issue Type: Improvement
> Components: Storage
> Reporter: Jihoon Son
> Assignee: Jihoon Son
> Fix For: 0.12.0
>
>
> We need to improve Fragment interface consistent for various types of
> fragments.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
