[
https://issues.apache.org/jira/browse/TAJO-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15288065#comment-15288065
]
ASF GitHub Bot commented on TAJO-2156:
--------------------------------------
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/1027#issuecomment-219903294
This changes should be added tests.
If you change GeoIP to GeoIP2, it would be better for tests.
please see the lincese and csv database for testing
http://maxmind.github.io/GeoIP2-java
https://dev.maxmind.com/geoip/geoip2/geoip2-city-country-csv-databases
> Create GeoIP functions taking various types instead of INET4 type
> ------------------------------------------------------------------
>
> Key: TAJO-2156
> URL: https://issues.apache.org/jira/browse/TAJO-2156
> Project: Tajo
> Issue Type: Sub-task
> Components: Function/UDF
> Affects Versions: 0.11.2
> Environment: Due to TAJO-2130, INET4 type geoip functions will be
> removed.
> To replace it, INT4 type functions could be added.
> Reporter: Jongyoung Park
> Assignee: Jongyoung Park
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)