Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/1036#discussion_r69850242
  
    --- Diff: 
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
 ---
    @@ -552,6 +552,16 @@ public static AlterTableDesc setProperty(String 
tableName, KeyValueSet params, A
         return alterTableDesc;
       }
     
    +  public static AlterTableDesc unsetProperty(String tableName, String[] 
propertyKeys, AlterTableType alterTableType) {
    --- End diff --
    
    Right. All those methods need to be refined. But, IMO, they are all 
internal APIs, and don't have to be consistent. So, I think that the new method 
has a better signature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to