[
https://issues.apache.org/jira/browse/TAJO-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380529#comment-15380529
]
ASF GitHub Bot commented on TAJO-2166:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1037#discussion_r71061666
--- Diff:
tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java
---
@@ -97,6 +98,17 @@ public final void testCreateTable2() throws Exception {
assertDatabaseNotExists("d2");
}
+ @Test
+ public final void testCreateTableWithCsv() throws Exception {
+ try {
+ executeString("CREATE TABLE D1.table1 (age int) using csv;").close();
+ fail("It should not reach here.");
+ } catch (Throwable e) {
+ assertEquals(e.getClass(), SQLSyntaxError.class);
--- End diff --
How about using JUnit's Expected Exception? You can simply check the
expected exception like in
https://github.com/apache/tajo/blob/master/tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalogExceptions.java#L65,
or do more things like described here
https://github.com/junit-team/junit4/wiki/Exception-testing.
> Disallow csv file format in DDL Languages
> -----------------------------------------
>
> Key: TAJO-2166
> URL: https://issues.apache.org/jira/browse/TAJO-2166
> Project: Tajo
> Issue Type: Improvement
> Reporter: Lee Dongjin
> Assignee: Lee Dongjin
> Priority: Minor
>
> csv file type is disallowed from ver 0.11.0. We have to remove it from DDL
> also.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
