[ 
https://issues.apache.org/jira/browse/TAJO-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382894#comment-15382894
 ] 

ASF GitHub Bot commented on TAJO-2177:
--------------------------------------

Github user hyunsik commented on the issue:

    https://github.com/apache/tajo/pull/1040
  
    +1 LGTM.


> In BroadcastJoinRule, the total volume of broadcast tables should be checked 
> before stages are merged
> -----------------------------------------------------------------------------------------------------
>
>                 Key: TAJO-2177
>                 URL: https://issues.apache.org/jira/browse/TAJO-2177
>             Project: Tajo
>          Issue Type: Bug
>          Components: Planner/Optimizer
>    Affects Versions: 0.11.3
>            Reporter: Jihoon Son
>            Assignee: Jihoon Son
>             Fix For: 0.12.0, 0.11.4
>
>
> Currently, one of broadcast candidates may be marked as not being 
> broadcastable because the total volume of the merged stage exceeds the 
> broadcast join threshold.
> This is done in BroadcastJoinRule::checkTotalSizeOfBroadcastableRelations(), 
> but it causes a bug because it doesn't split the merged stage into separate 
> ones again.
> This routine should be improved to check the total volume of broadcast 
> candidates before merging stages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to