[
https://issues.apache.org/jira/browse/TAJO-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419868#comment-15419868
]
ASF GitHub Bot commented on TAJO-2165:
--------------------------------------
GitHub user dongjinleekr opened a pull request:
https://github.com/apache/tajo/pull/1045
TAJO-2165: Disable unsetting timezone property
Hello. I just completed [TAJO-2170, Disable unsetting timezone
property](https://issues.apache.org/jira/browse/TAJO-2170). However, It would
be good to explain my decisions made on this issue. In short, it became a
little bit different from our initial expectation.
A little bit different from [your comment in
TAJO-2165](https://github.com/apache/tajo/pull/1036#issuecomment-230673810),
which became the starting point of this feature, I didn't move the timezone
property from KeyValueSet to TableMeta or TableDesc. Here is why:
- Our goal is to disable the removal of the timezone property from the
catalog. So, it is sufficient to keep this property from removal by raising
Error when the user attempts to remove it from the catalog storage; However,
KeyValueSet, TableMeta and TableDesc are all components in alter table message,
not storage. So, they don't need to be modified.
- If we modify KeyValueSet, TableMeta or TableDesc, we have to reconduct
similar task every time some new unremovable properties are added. This
repetitive task does not worth.
With above reasons, I decided not to modify KeyValueSet, TableMeta or
TableDesc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjinleekr/tajo feature/TAJO-2170
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/1045.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1045
----
commit b66ce500134637cba052addb80586e9ca5d2be26
Author: Lee Dongjin <[email protected]>
Date: 2016-08-13T09:07:48Z
Define new error code: UNREMOVABLE_TABLE_PROPERTY (1007)
commit cd1f2bf098c3a8eef6adb399a99b6a6e5b73961b
Author: Lee Dongjin <[email protected]>
Date: 2016-08-13T09:17:23Z
Define UnremovableTablePropertyException
commit 3cfd8875cc7b48cef87b94e491c337a27c58dbc3
Author: Lee Dongjin <[email protected]>
Date: 2016-08-13T09:57:40Z
Disable unsetting timezone property
----
> Add 'ALTER TABLE UNSET PROPERTY' statement to Tajo DDL
> ------------------------------------------------------
>
> Key: TAJO-2165
> URL: https://issues.apache.org/jira/browse/TAJO-2165
> Project: Tajo
> Issue Type: New Feature
> Components: SQL Shell
> Reporter: Lee Dongjin
> Assignee: Lee Dongjin
> Fix For: 0.12.0
>
>
> For version 0.11.x now, there is only set statement for table property. When
> the user makes a typo with DDL statement, this mistake cannot be removed. We
> also need the way to remove already set properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
