Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/1047#discussion_r76527398
  
    --- Diff: 
tajo-catalog/tajo-catalog-drivers/tajo-hive/src/main/java/org/apache/tajo/catalog/store/HiveCatalogStore.java
 ---
    @@ -789,6 +793,44 @@ private void dropPartition(String databaseName, String 
tableName, CatalogProtos.
         }
       }
     
    +  private void setProperties(final String databaseName, final String 
tableName,
    +                             final PrimitiveProtos.KeyValueSetProto 
properties) {
    +    HiveCatalogStoreClientPool.HiveCatalogStoreClient client = null;
    +    try {
    +      client = clientPool.getClient();
    +      Table table = client.getHiveClient().getTable(databaseName, 
tableName);
    +      table.getParameters().putAll(ProtoUtil.convertToMap(properties));
    +       client.getHiveClient().alter_table(databaseName, tableName, table);
    +    } catch (NoSuchObjectException nsoe) {
    +    } catch (Exception e) {
    +      throw new TajoInternalError(e);
    +    } finally {
    +      if (client != null) {
    +        client.release();
    +      }
    +    }
    +  }
    +
    +  private void unsetProperties(final String databaseName, final String 
tableName,
    +                               PrimitiveProtos.StringListProto 
propertyKeys) {
    +    HiveCatalogStoreClientPool.HiveCatalogStoreClient client = null;
    +    try {
    +      client = clientPool.getClient();
    +      Table table = client.getHiveClient().getTable(databaseName, 
tableName);
    +       for (String propertyKey : ProtoUtil.convertStrings(propertyKeys)) {
    --- End diff --
    
    please fix indentation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to