> On Jan. 27, 2014, 5:28 p.m., Jihoon Son wrote: > > Ship It!
Thank you for the reviews! - Hyunsik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16898/#review32818 ----------------------------------------------------------- On Jan. 27, 2014, 5:24 p.m., Min Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16898/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 5:24 p.m.) > > > Review request for Tajo, Hyunsik Choi and Jihoon Son. > > > Bugs: TAJO-475 > https://issues.apache.org/jira/browse/TAJO-475 > > > Repository: tajo > > > Description > ------- > > Some of the changes don't directly related to this recap, but triggers some > of the bugs of tajo. This patch will fail in the test cases if I didn't fix > those bugs. > > > Diffs > ----- > > CHANGES.txt c66504d348ff384659f62638aa2e086a97918332 > tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java > 87405b024d35da0890aa75d6fe651f3e6d86e652 > > tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java > 981e0628fb43409873c51c9f8c4cb9b38b5ceb87 > > tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/CatalogService.java > c6bd7fbf754b822e5ec30275bf01988c5badc74d > tajo-catalog/tajo-catalog-client/src/main/proto/CatalogProtocol.proto > 6374278be36897ce36d4c4f6831739ffbd72ec3c > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java > ed23b085ecedcdb9ce649a331efbb91da42d280e > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java > dc91035313caf22312edecabe7fc29db03b64de0 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java > c818be7b1dd18533e6e741afed46727ca6e56c7d > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/IndexDesc.java > 9465946587e4c8cc6bf6a89e77189dd3d7e65ffc > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java > a19d35270445fb00a6901b8e6d54e3fb2829f3f7 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java > 8fffc6e523cd905100d61aa7dfc8a15a98cfe49c > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java > c3e31d8258590f5d857294184f7a42b4c82f597d > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java > PRE-CREATION > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/Specifier.java > feb8a339a0c7343a1647ae6b6c000c2445e55941 > tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto > beff4c740045cc5fb84f5c71659bc24fe72105d6 > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java > e24412e419982ad8807f5cd869842bd2068dcd4f > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java > 225d92e5ffdd22b3c7480592589091ad32aabec8 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java > c69487afd36992244dc6bb67e7e234d1875c2fab > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java > 60c88e99c874a022a1e2e3cc48fe21d7c39f0c11 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java > 44f4e7aa480e04b669b655a7b2e88beb01be7e73 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java > f21ab0e0b62b805f4725c04c55a6263f193d44ac > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java > 77b258efdab1ca940296154189dc0e1212c02e56 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java > c36896950dea6c0c8773b708e98fdc8b1a705791 > > tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java > 9b10f9046bbda6c18ef2838b0923d4127a300683 > > tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestDBStore.java > 1949afcd53210806ee50042eca013b83c9f6b638 > tajo-client/src/main/java/org/apache/tajo/cli/DescTableCommand.java > b4678c0ef294615bd203f788b282cdc104ad0264 > tajo-client/src/main/proto/ClientProtos.proto > d75b5afffa74163410c5d76e3b921209a69fbe71 > tajo-core/tajo-core-backend/pom.xml > abc217e1a193b406a80970f6cbef76a3b385a558 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java > 5507ba0d466a08fc615acbc8b4f4269bd490d085 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/InsertNode.java > 3dd371bc8e18579585a6a60e1d15214545c5bca2 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java > 902cbeebb45c4116d2fa22095d6b975bf5dfdaa6 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java > 066a3bb0338dea2c67f904ce16eddf3ba2095198 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java > 7de053b535c6735a02db58d962af86a9c208cc79 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java > 663954edcf04be71072a910ff89a4b8a9237046d > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java > 3e756d54869d39fd2f2d31ce824d0464c68cc426 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/CreateTableNode.java > 66a235567b35538befdc76a3f545fe4f40f18523 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/PartitionedTableScanNode.java > d687829b09d4babede8afe2255520ff91b3132e4 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/PersistentStoreNode.java > 1bd354889aedd3893f2d7976f0c63923643fb2cd > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/ScanNode.java > 165e1e8bcc41b69295319ce6674a120da2541c0d > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/ShuffleFileWriteNode.java > 3abec9d699431cf63084041de0066e8413899259 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/StoreTableNode.java > 2aca6a75d10a3b682b9386ad9ba7c4196cb93484 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/ColumnPartitionedTableStoreExec.java > 338d2f23effc47527875888e6394db2fcae5c657 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/HashAggregateExec.java > d533b823ce420d1ef85cd7efb962c4e56656102a > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java > c38be9252890e44c592e592ce2d0beb5c5063a2b > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/PartitionedTableRewriter.java > 041220a00862cfe3035f9b62bc68fd0015422932 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java > e70e6c29703321ef76f62d50216c3b7fc1c7a6e7 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/query/QueryContext.java > e710f9d4113f1e74fdbd4ab4e8730eab9ed5f753 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/SchemaUtil.java > df49503282cfb7758f2e5fd9fab2d6a239aed319 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java > a9693263bd56506464ce6a507916c0fd361b3346 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java > 35e6dd9d004aa27590795f75d0500373c38ced7d > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java > 7e4540bc36a32c4ccceaa179526d8136ba653592 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestDDLBuilder.java > 7f9d15cc62428e9230f24afb2928270ff6318115 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestTajoClient.java > 174f2046f59c5f81814376f25a6c3f2c25ea9159 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveConverter.java > 2e4221d11df2a193e3cc1b2a5cf07d267272c1f9 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestSQLAnalyzer.java > e81326e3a263995c8a9e661084143cc270ca42ee > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java > 9eb027693d714661decbf96c75aac4984e74c5e2 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java > b117f64b989035fe559105bf147dbceb937bcd31 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java > ca5c07108af9d23459d9bd4a913bc5bc7df6039c > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java > 7f10736fe75b6acad6780877b6a234275d68d4c9 > tajo-core/tajo-core-backend/src/test/resources/results/testBuildDDL.result > 4fd87c2469eb00a28585a41fd97f842b68a9bb57 > > Diff: https://reviews.apache.org/r/16898/diff/ > > > Testing > ------- > > mvn > > > Thanks, > > Min Zhou > >
