----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17448/#review32978 -----------------------------------------------------------
Hyunsik, Could you check unittest ? ``` Results : Failed tests: testCtasWithGroupby(org.apache.tajo.engine.query.TestCTASQuery): Result Verification expected:<...-------------------(..) testCtasWithOrderby(org.apache.tajo.engine.query.TestCTASQuery): Result Verification expected:<...-------------------(..) testCtasWithLimit(org.apache.tajo.engine.query.TestCTASQuery): Result Verification expected:<...-------------------(..) Tests run: 510, Failures: 3, Errors: 0, Skipped: 0 ``` - Jinho Kim On Jan. 28, 2014, 8:44 a.m., Hyunsik Choi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17448/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 8:44 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-560 > https://issues.apache.org/jira/browse/TAJO-560 > > > Repository: tajo > > > Description > ------- > > Take a look at the following query. This kind of queries can cause invalid > distributed plans. > {code} > create table testCtasWithUnion (col1 int4, col2 int4) partition by column(key > float8) as > > select > * > from ( > > select > sum(l_orderkey) as total1, > avg(l_partkey) as total2, > l_quantity as key > from > lineitem > group by > l_quantity > order by > l_quantity > limit > 3 > > union > > select > sum(l_orderkey) as total1, > avg(l_partkey) as total2, > l_quantity as key > from > lineitem > group by > l_quantity > order by > l_quantity > limit > 3 > > ) t1; > {code} > > > Diffs > ----- > > CHANGES.txt 029ea49f0bdae82846a0eecfa2d8aa85e4df047d > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java > 6e44bb87e7cffa7916f3df62dc6dca40a1ff1d0d > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java > aacf5887701f3a09bddecea3f061168e4e832a2b > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java > a17a9f534da56dddde04dfbfb0a5d95d6a1647a0 > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithGroupby.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithLimit.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithOrderby.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithUnion.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/check1.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/check2.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithColumnedPartition.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithGroupby.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithLimit.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithOrderby.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithUnion.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithoutTableDefinition.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSelectQuery/testSelectAsterisk1.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSelectQuery/testSelectAsterisk2.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSelectQuery/testSelectAsterisk3.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithGroupby.result > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithLimit.result > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithOrderby.result > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithUnion.result > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestSelectQuery/testSelectAsterik.result > > > tajo-core/tajo-core-backend/src/test/resources/results/TestSelectQuery/testSelectAsterisk2.result > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestSelectQuery/testSelectAsterisk3.result > PRE-CREATION > > Diff: https://reviews.apache.org/r/17448/diff/ > > > Testing > ------- > > > Thanks, > > Hyunsik Choi > >
