-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17482/
-----------------------------------------------------------
(Updated Jan. 29, 2014, 1:49 p.m.)
Review request for Tajo.
Bugs: TAJO-567
https://issues.apache.org/jira/browse/TAJO-567
Repository: tajo
Description
-------
This patch fixes two cases of expression projection bugs. Please take a look at
two example cases:
The point of this case is outer join and constant expression.
{code}
select c_custkey, o.o_orderkey, val as val from customer left outer join
(select * from orders) o on c_custkey = o.o_orderkey
{code}
The point of this case is non-column grouping keys.
{code}
select upper(lower(l_orderkey::text)) as key, count(1) as total from lineitem
group by upper(lower(l_orderkey::text)) order by
upper(lower(l_orderkey::text)), total;
{code}
Diffs
-----
tajo-algebra/src/main/java/org/apache/tajo/algebra/Aggregation.java
376963fb56c302912f7a38981b8f5f9b808749e8
tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java
1836f517d26bed4206f58f85c7583f7ee2f23a50
tajo-algebra/src/main/java/org/apache/tajo/algebra/FunctionExpr.java
7f1dcd353bbfaa784a03a58a182ffb586863a6d4
tajo-algebra/src/main/java/org/apache/tajo/algebra/Insert.java
c58c040a7b4be6fb03a2b72a93781eed1b31c896
tajo-algebra/src/main/java/org/apache/tajo/algebra/Join.java
da2b153c07894ee01789a97cea663e74151d20fe
tajo-algebra/src/main/java/org/apache/tajo/algebra/Projection.java
bcb6253ac9d7c4516b17bb2a49d48a6e819cf13b
tajo-algebra/src/main/java/org/apache/tajo/algebra/TablePrimarySubQuery.java
90d89a4368429a50d19f99568856cd48af98beb7
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java
00a687cf5ebbecc9fb3d31c36aef5c0d23ebc339
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
abc3832f92d460c746e700326b4f2d3a182ffa45
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/NamedExprsManager.java
893fbe1c9741e5e7e6f05d232b05a338ad90b6c5
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java
4e604487f96572af5f023287445f6b8b8cc0ff97
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
8bb2c28ddb588729adfcb017b284b601b5fdf1b9
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java
a9f7849d22a30fbc289cb5755669c620474ae196
tajo-core/tajo-core-backend/src/test/resources/queries/TestGroupByQuery/testGroupByWithConstantKeys1.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestGroupByQuery/testGroupByWithExpressionKeys1.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestGroupByQuery/testGroupByWithExpressionKeys2.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testLeftOuterJoinWithConstantExpr1.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testLeftOuterJoinWithConstantExpr2.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestGroupByQuery/testGroupByWithExpressionKeys1.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestGroupByQuery/testGroupByWithExpressionKeys2.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestJoinQuery/testLeftOuterJoinWithConstantExpr1.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestJoinQuery/testLeftOuterJoinWithConstantExpr2.result
PRE-CREATION
Diff: https://reviews.apache.org/r/17482/diff/
Testing (updated)
-------
mvn clean install
Thanks,
Hyunsik Choi
