> On Feb. 3, 2014, 7:07 p.m., Jung JaeHwa wrote: > > CHANGES.txt, line 243 > > <https://reviews.apache.org/r/17589/diff/1/?file=457661#file457661line243> > > > > It conflicted with latest source.
hunk can be either succeeded or failed. But, this case is succeeded. I think that we should regard it as success. Otherwise, we would rebase the patch too frequently. - Hyunsik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17589/#review33418 ----------------------------------------------------------- On Feb. 2, 2014, 12:20 a.m., Hyunsik Choi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17589/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2014, 12:20 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-568 > https://issues.apache.org/jira/browse/TAJO-568 > > > Repository: tajo > > > Description > ------- > > See the title and the following case: > {code} > select a.id, a.name from (select id, name from table1) a > union all > select a.id, a.name from (select id, name from table1) a > {code} > > We should fix it. > > > Diffs > ----- > > CHANGES.txt f038f979d1e8732fc380fe878217be90df8d0153 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java > 586ef680e93c20e57a5dcff85b8e4135ec3e1a6f > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlan.java > 208b18dbb82f99613b4a57dec5975c712607ba6a > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java > 169ed234b7a26b5c7297eb2d363089ec36caf2cd > > tajo-core/tajo-core-backend/src/test/resources/queries/TestUnionQuery/testUnionWithSameAliasNames.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestUnionQuery/testUnionWithSameAliasNames.result > PRE-CREATION > > Diff: https://reviews.apache.org/r/17589/diff/ > > > Testing > ------- > > mvn clean install > > > Thanks, > > Hyunsik Choi > >
