----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17743/#review33771 -----------------------------------------------------------
Ship it! +1. This patch looks good to me. Beyond this issue, the default block size is 128MB in Hadoop 2.2.0. So, we should increase the default task size, too. Would you mind changing the default task size before you commit the patch? - Jihoon Son On Feb. 6, 2014, 4:30 p.m., Jinho Kim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17743/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 4:30 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-588 > https://issues.apache.org/jira/browse/TAJO-588 > > > Repository: tajo > > > Description > ------- > > Leaf task of DefaultTaskScheduler should be fragment size > If initial request of leaf task is small size, most tasks will be allocate to > single node. > > > Diffs > ----- > > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java > d8b7d75116fc2deab4bfa681d6a66bd1f023ba13 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java > a2291690a3f77ffc08013d556a1d49ab3828ce60 > > Diff: https://reviews.apache.org/r/17743/diff/ > > > Testing > ------- > > > Thanks, > > Jinho Kim > >
