-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17728/
-----------------------------------------------------------
(Updated Feb. 7, 2014, 2:12 p.m.)
Review request for Tajo.
Changes
-------
Added additional unit tests and fixed found bugs.
Bugs: TAJO-583
https://issues.apache.org/jira/browse/TAJO-583
Repository: tajo
Description
-------
Broadcast join does not work on partitioned tables. This is because broadcast
join condition just checks ScanNode whose data volume is smaller than some
threshold. We should also consider PartitionedTableScan.
Diffs (updated)
-----
CHANGES.txt 36c106211f3f1c224f58174e8e261d0102a70f38
tajo-common/src/main/java/org/apache/tajo/util/TUtil.java
e9d82197671dabf6388e26a42a3a1bf37145e61c
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java
b8c52c0147bae6e1f29cf3c71d5969709672e410
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlanString.java
ef8bed0d95c0ee92e7c37d9d9307a97f575c1733
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java
bd9001c679f7d9b0914760c83ca10891c0ce0fd4
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/ExecutionBlock.java
4f3976e804a621e8eee4aaca96097256f9cfc6b1
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
cb2ac1536791626ae151dc5ac62e5d293c90813d
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/MasterPlan.java
f6ac2befc2bc4c45e07cfafe6d01bf4c6f303412
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java
d0c989758334cfb3f2bd7605c118ec1271b8c31f
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PartitionMergeScanExec.java
PRE-CREATION
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/FilterPushDownRule.java
68a0e305673c0894977d70ac1ed838228a10ed59
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java
7512f23533cce31a4f87e5badf0296da71806124
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
0f4a62b319805b89f6aebc6e49b82aa3ee11d3a8
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
02c2f6a5e264ab985be31bc7ef612ca2eb3f693e
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java
fa67eb694b082439fdd27f630329875a878f5c32
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java
24a4237ed3c46c87ee480e36a40402102dfe5531
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TajoTestingCluster.java
6e73df88d6ab37c8466667a9a87a5f447ff3c03b
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TpchTestBase.java
ad3d67668b9c112f05f0af296a47f3e27ba2546b
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java
07f726db109d8aa45510adeb2cda25e9848b063e
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
ede0d584cfa9350d820e0ab64e3d1cf65b95b170
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinOnPartitionedTables.java
PRE-CREATION
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
46c1d94ef8c3824ccefedd00fe7e074e0537ecb6
tajo-core/tajo-core-backend/src/test/resources/queries/TestGroupByQuery/testGroupByNested1.sql
10fa4239a79cb550873f7601fc176ceb5c7bdd7f
tajo-core/tajo-core-backend/src/test/resources/queries/TestGroupByQuery/testGroupByNested2.sql
e7bbcac1dbd2207693adf09aa29ca2c06976e88e
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinOnPartitionedTables/customer_ddl.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinOnPartitionedTables/insert_into_customer.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinOnPartitionedTables/selfJoinOfPartitionedTable.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinOnPartitionedTables/testNoProjectionJoinQual.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinOnPartitionedTables/testPartialFilterPushDown.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinOnPartitionedTables/testPartitionTableJoinSmallTable.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testFullOuterJoin1.sql
221b8a95c31fcb57c9a4c5bee1279714af7b6878
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testLeftOuterJoin1.sql
59a876af8e8d6dbbcacdf315f806cab9e48b7254
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testLeftOuterJoinWithConstantExpr1.sql
334c161f259f161967d735da12b032895ece560c
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testLeftOuterJoinWithConstantExpr2.sql
3256e28160c3356d79ae414d89a3578b6ca986d0
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testLeftOuterJoinWithConstantExpr3.sql
03cdae2cdadec2042ae455c6c20f41437b0ee11b
tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testRightOuterJoin1.sql
cf9896d6c253a8213de6761d9a1360d9b6ed8606
tajo-core/tajo-core-backend/src/test/resources/queries/TestTablePartitions/case3.sql
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/queries/default/create_partitioned_table_as_select.sql
09b14eb0b6359119d6a48f4e3de1ab6428571cdd
tajo-core/tajo-core-backend/src/test/resources/results/TestGroupByQuery/testGroupByNested1.result
85c55983fd5b17adf9e432cfc2951ebffa524aa8
tajo-core/tajo-core-backend/src/test/resources/results/TestGroupByQuery/testGroupByNested2.result
edae882317118e0354b34543bdc98322a753a467
tajo-core/tajo-core-backend/src/test/resources/results/TestJoinOnPartitionedTables/selfJoinOfPartitionedTable.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestJoinOnPartitionedTables/testNoProjectionJoinQual.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestJoinOnPartitionedTables/testPartialFilterPushDown.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestJoinOnPartitionedTables/testPartitionTableJoinSmallTable.result
PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestTablePartitions/case3.result
PRE-CREATION
tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java
5d05d6f1fe039f9f53b777ea3b1a61a136af133b
Diff: https://reviews.apache.org/r/17728/diff/
Testing
-------
mvn clean install
Thanks,
Hyunsik Choi
