----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17642/#review34029 -----------------------------------------------------------
I'm very sorry for too late response. I'm reviewing this patch. I've just tried to do unit tests. Almost all are passed well, but the unit tests of TestHiveQLConverter are failed. Could you check these tests? Thank! - Hyunsik Choi On Feb. 8, 2014, 3:38 a.m., Jihoon Son wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17642/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2014, 3:38 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-554 > https://issues.apache.org/jira/browse/TAJO-554 > > > Repository: tajo > > > Description > ------- > > See the title. LogicalPlanner should allow the following case. > > SELECT *, col1 + 10, col2 FROM ... > > In this patch, the asterisk expression is replaced with the target relation's > columns in LogicalPlanPreprocessor. > > > Diffs > ----- > > > tajo-algebra/src/main/java/org/apache/tajo/algebra/AsteriskedQualifierExpr.java > PRE-CREATION > tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java 84f784e > tajo-algebra/src/main/java/org/apache/tajo/algebra/Projection.java 3d9f8a6 > > tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 > ab6bff6 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveConverter.java > a8a555b > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java > 493f892 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java > 1c710dc > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java > 6cc6fd0 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java > f25064f > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprNormalizer.java > 6363bf6 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java > 0831b0a > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java > 586ef68 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java > 3b4ec89 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java > 81f57d4 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java > 5e5c70c > > tajo-core/tajo-core-backend/src/test/resources/queries/TestSortQuery/testAsterisk.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/results/TestSortQuery/testAsterisk.result > PRE-CREATION > > Diff: https://reviews.apache.org/r/17642/diff/ > > > Testing > ------- > > mvn install -DskipTests > > > Thanks, > > Jihoon Son > >
