[
https://issues.apache.org/jira/browse/TAJO-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896747#comment-13896747
]
Tajo QA commented on TAJO-593:
------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12628001/TAJO-593.patch
against master revision 4179a7c.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:red}-1 tests included.{color} The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:red}-1 findbugs.{color} The patch appears to introduce 192 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests.{color} The patch passed unit tests in
tajo-core/tajo-core-backend.
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/116//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/116//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/116//console
This message is automatically generated.
> outer groupby and groupby in derived table causes only one shuffle output
> number
> --------------------------------------------------------------------------------
>
> Key: TAJO-593
> URL: https://issues.apache.org/jira/browse/TAJO-593
> Project: Tajo
> Issue Type: Bug
> Components: distributed query plan
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.8-incubating
>
> Attachments: TAJO-593.patch
>
>
> See the following query case:
> {code:sql}
> select count(*) from (select l_orderkey, l_partkey, count(*) from lineitem
> group by l_orderkey, l_partkey) t1;
> {code}
> In this case, SubQuery::calculateShuffleOutputNum() are used two times for
> choosing the number of shuffle outputs. At that time,
> SubQuery::calculateShuffleOutputNum() method finds GroupByNode to know the
> number of grouping keys. Here is one bug.
> SubQuery::calculateShuffleOutputNum() always the topmost GroupByNode. In most
> cases, it work well. But, outer groupby and groupby in derived table can
> cause the problem. In this case, we must use the most bottom groupby node.
> Actually, it is always the correct way.
> This patch fixes SubQuery::calculateShuffleOutputNum() to use the most bottom
> groupby node.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
