-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18164/#review34632
-----------------------------------------------------------



tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java
<https://reviews.apache.org/r/18164/#comment64823>

    Hi, Hyunsik.
    
    How about adding "appender.close" after if condition clause?


- Jung JaeHwa


On Feb. 17, 2014, 7:57 a.m., Hyunsik Choi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18164/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 7:57 a.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-305
>     https://issues.apache.org/jira/browse/TAJO-305
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> In the current version, killQuery feature is partially implemented. We need 
> to complete this feature and add a command to tsql.
> 
> 
> Diffs
> -----
> 
>   tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java 
> 57a7294a8d2563a6cbaa9f56befa9843b0b1fdbf 
>   tajo-client/src/main/java/org/apache/tajo/client/TajoAdmin.java 
> 98939a5a7c66ba532b7eb0516243a1d4d96a1a7f 
>   tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java 
> 3aeb40e81ce7f2902c6ae40a8bfe2259ef2dca35 
>   tajo-common/src/main/proto/tajo_protos.proto 
> d3373151fda2ea5005fa4ee8c5ad3f568e97822b 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/builtin/Sleep.java
>  PRE-CREATION 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SortBasedColPartitionStoreExec.java
>  99d673b13a61c6d01b27d169202a35cf3180614f 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/AbstractTaskScheduler.java
>  acb1dcc01ec6d8df618f3e28637cb81817b243e7 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/DefaultTaskScheduler.java
>  4260c98798615dc071473fcd4519e8eccc86e62f 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoContainerProxy.java
>  f405ea7d229830d8c82f154685eb27a80f2c4c88 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
>  0f8eb61ce57f2aebff2c6d91d77fbaaee89ee688 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/event/LocalTaskEvent.java
>  PRE-CREATION 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/event/QueryCompletedEvent.java
>  PRE-CREATION 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/event/QueryEventType.java
>  d5f7e3836ec88ffa8440499c5d58e48127c0d829 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/event/QueryFinishEvent.java
>  9c81132f659b38b9f92e5dbb8e3b0c5a941fbd48 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/event/SubQueryCompletedEvent.java
>  7e07525a6448f4a7046988c1ca61b65f8d610097 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/event/SubQueryEventType.java
>  2e56c79cedb2b4d79080275921cecb143be317ab 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/event/SubQuerySucceeEvent.java
>  24854218311b57008aa50020b6f8752f664b78d7 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/event/SubQueryTaskEvent.java
>  0217f207adb7d2e957ceaca030184d0f7722b39d 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/event/TaskAttemptEventType.java
>  d9d2f13392f06e35932feded581c7928cac749ac 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/event/TaskSchedulerEvent.java
>  9fe2f8c4b650748f3b53eb60848fa490128e187c 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java
>  f4a6da7fa140e21d025128d9f20b73cff5a31105 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryInProgress.java
>  2a93d3c2588d0e89a144c5784524791daf95d2c8 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryJobEvent.java
>  b2c129feb05a0943c7014f4081a927d85090656e 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterManagerService.java
>  5ce57f742d2a7dfa6f347682d15c7a5e41e79554 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
>  eb0528c535c43b1daa31e7977a7bd367f79675a5 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnit.java
>  a0f3dfda00c3edfeb6fbd27e7d61ecd22c153780 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java
>  f5001ccb6c9deb73999371be4285955233377971 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
>  bcdba43208c14c5a436e5ee55c36944828026edb 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQueryState.java
>  ce4d209ad8b35e71f174a473bd13b37eb7234146 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
>  16427b65c2e2f07e002d345690ab623f17435126 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java
>  da3dc346a1801d97036cc49b998546c6af978a3e 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoWorkerManagerService.java
>  c7706963d82b4daf61eca9d3f653d47edb82ffa9 
>   tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java 
> c31e9cdb4806ce29b57e254165764135e4de5795 
>   
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TaskRunner.java
>  7b49c150a33883b402237708f81735a679704b26 
>   tajo-core/tajo-core-backend/src/main/proto/QueryMasterProtocol.proto 
> fe5bf03105f5cb8d6ed19740817eb32f421f8208 
>   tajo-core/tajo-core-backend/src/main/proto/TajoWorkerProtocol.proto 
> e08da29883d693c3321ec1bb12c26c8beba7e32b 
>   tajo-core/tajo-core-backend/src/main/resources/webapps/admin/query.jsp 
> 80259c8ecccf44ae6569921b4ceb781fe7469f83 
>   
> tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querydetail.jsp 
> 7656dfbd955bbfea2bf2e7f05527403253c5e211 
>   
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestTajoClient.java
>  13db0d03f34574f8a6619155129c0f06c7253c77 
> 
> Diff: https://reviews.apache.org/r/18164/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install.
> 
> 
> Thanks,
> 
> Hyunsik Choi
> 
>

Reply via email to