-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18274/
-----------------------------------------------------------
(Updated Feb. 20, 2014, 1:56 a.m.)
Review request for Tajo.
Bugs: TAJO-610
https://issues.apache.org/jira/browse/TAJO-610
Repository: tajo
Description
-------
Column class has some ambiguous methods and some complex logics.
This patch simplifies and refactors Column class as follows:
* Rename getColumnNum() to size()
* Remove qualifier variable from Column and ColumnProto
* Rename getColumnName to getSimpleName
* Move some codes for qualification and simple name to CatalogUtil and
refactor them for common identifiers including database, table and column names
* Change Column as an immutable object
Diffs
-----
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
9f143acaab1ce58f2c0b2a3fe2f31db05d3709e7
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Column.java
cb420867db5bf424284b046de704e3c2375a2836
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java
12a1f744a035adfab45ce809c95d97fb959958ba
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
5f1e8d70a393b3cb2ca122ddc123a719e5d3f679
tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto
47792a605d28ca11c256d030045fee2f84cdb46e
tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestColumn.java
81677c51515e2aa8d28197692fc316e4d4de233d
tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestSchema.java
c879ecb2995fd179e883f3665259b28ef9551ee4
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
ae8a7d1d275409f7e33e1781d7422fa882ea236a
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
e05e0ae5588646b6aec62886e14e5a7bd86a880b
tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
441ffe54df676a493cfcecbedce6ddedb5468e75
tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestDBStore.java
502daf0dd871b5f575bdba3bedbf2109662eca42
tajo-client/src/main/java/org/apache/tajo/cli/DescTableCommand.java
8bf00e1f0d26c2051149754a3128f5995809c5d3
tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSetMetaData.java
98df048b5fcdff801ec7a4db511e7872d3ab0e38
tajo-common/src/main/java/org/apache/tajo/TajoConstants.java
8cdc7bbdbb494212f3d5c32bf11982f306a7b9ab
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/EvalTreeUtil.java
da05739b8feff0e04b1762f8000b1f3818c773a2
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/FieldEval.java
dc9b35b88127e40b0573cdedbc09d992d055f95b
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java
47bd1663c3a2239f9433cea272ff146a8b4ba486
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java
a6bedcf0a2ad0640ae8e8e12ccff4b1fdd4bd80b
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanVerifier.java
6800519f26b3f2f177eaae153978a41daeb85b23
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
f7c0bfab78cb3416e7a2ed263cc362917023e3ca
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java
624518b534a6214e2a2908e21ea977254b23368c
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/DataChannel.java
9f5c6bf9dd7b549308724ce1e8044aff1630cef1
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
f390b52f378a2d7e84e40876df4a4b416af912ef
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/GroupbyNode.java
a7f36ec9bf095739414be2896f505e8cf5b19cc1
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/ScanNode.java
aa91090dd9d962b28d7ec99d7012528a4ca63ec0
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/SortNode.java
8154016d46aa34ebe121d055131612ba4c02dca5
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/TableSubQueryNode.java
e2054544849a1dc402008591930383c8de3f2361
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/join/JoinGraph.java
9d66dd5e9e5aa27a3c3ea3f7e7fafc21b3ebc876
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/BNLJoinExec.java
71581e3c82951a57e2735c414f8178eaade92fce
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/BSTIndexScanExec.java
753dcc84a2856652b8acbd512d0362705db73324
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/ColPartitionStoreExec.java
c81f3bd328c4b5990f8c80db56edb67c2f1e5bc6
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/HashAggregateExec.java
1f8d00075ff053d9ea37158badf77ccd0ee6b69f
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/HashFullOuterJoinExec.java
70dd10b65b408f665654adf5cba215ff602e95cc
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/HashJoinExec.java
51d0b4cc5781877da5228a2b92e5d41c63c3d920
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/HashLeftOuterJoinExec.java
93383a34a6ac508812a93db10661a51f7e0747b6
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/MergeFullOuterJoinExec.java
613e072ab839ec215d92f95f91d8d68c1936607c
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/MergeJoinExec.java
f72e87eb1d3c1f5d3a5e01e1628644087cec22b5
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/NLJoinExec.java
961be9334ea6d2f5e7818efcf09bdc0198073aea
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/NLLeftOuterJoinExec.java
4abe57093db3dd8ac392d1a24e2acef5ec1f9516
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/PhysicalExec.java
033dcd9269d852156b56a6f1658b9b263ff0219d
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/ProjectionExec.java
e205751b6bba4ab836683966686eab99ed6dc5ad
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/RangeShuffleFileWriteExec.java
698e46e25ce669bc7c9d19717ccdcf6338690095
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/RightOuterMergeJoinExec.java
b49454470b62936b0f80dfb3fb1aa699e8940919
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SortAggregateExec.java
dbe45dcfccf31ff9e85407deaeb5f1a0963ff85d
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/PartitionedTableRewriter.java
e5f7fb40414e0b2e2e40bccebe24069ee4d9301b
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/query/QueryContext.java
4a3bf46857ec648094e464c5c2a2fc69be9f29de
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/SchemaUtil.java
c9ab8239bc065268fee7315b8d048211f28e5d2e
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/TupleUtil.java
b96b65e2926a5bcfa8f0b995b3f52059ee07c7c4
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/IndexUtil.java
dc777007b814f5fe0e0dea201c71fa8dc4c83fd0
tajo-core/tajo-core-backend/src/main/resources/webapps/admin/catalogview.jsp
26212f037648d309d73f640bc4d1ba771e96bbd5
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
dea4fc841214bf33eab4fe9b78e002ae0c4681b2
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java
d7562426647a6a9d6aae5207a67ddcdd03d0ee3a
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestLogicalOptimizer.java
92faec09b61d1692e74bdf348ce7c9c0ea5642e2
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestLogicalPlanner.java
f9cbcf98676be5038ef97ec97055151eb93665c2
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/TestPlannerUtil.java
00ce501f115ec8784050c3fd19145694ab3db8e0
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestBNLJoinExec.java
235fbcf54338f9d3270e1768ed9b5d65f61096b7
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java
97932e761bce3164411f96e05ee49833885f8c76
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestExternalSortExec.java
a2a2b541ec350e114eb97bde4b2e53a5b6398389
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterHashJoinExec.java
63f14b786d94f52fdd3229a233505fb1ac467d38
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestFullOuterMergeJoinExec.java
c92d1c9d63045d5ff2cd92b363df7fca78f0edc5
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestHashAntiJoinExec.java
f4350fb0fad0850c1c2242d5a0feab171000c388
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java
48cd2655a5d09aedbed92ff6c15fa1cc07246d08
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestHashSemiJoinExec.java
8eec32478c51d9f13b06d5384620ed91df8b3162
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterHashJoinExec.java
e163a2919876796bd978788c9ffa340c433d7ebc
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestLeftOuterNLJoinExec.java
0540bc1bfcff425d54a5e712bd1c805120b86737
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestMergeJoinExec.java
af7254188e63518d31d57002afaaeca2fef5e0fd
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestNLJoinExec.java
004cb57c6b3bb9a94fea231c742c706e9afdd15e
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
72462ded06f9cbfc60cc988c270274ea0b9f93fb
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterHashJoinExec.java
b52a37ad3a528e9df6831459a1685ab72901e917
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestRightOuterMergeJoinExec.java
5bbb4aa79e92e111b5a75ccce9d68841ac665550
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestSortExec.java
7e8c118c33eb99ce12d6c08770840ea4c6792de1
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
9b940daac43cbb95164803d37e48973ea0a39ab7
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
f775acb7b8ea0831fb9bb6f714180a561f101432
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/jdbc/TestResultSet.java
aff996b1f3bbd1d6772262d2c608d9df001e88b4
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java
2313388479217a3d20cf6a58a28f3d53acfc21b0
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java
b18f706efd11942791464147b847250a2d106b67
tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java
2637e6bc8cadd9e601e84a88f10ee14c9e55fa90
tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java
490787f216943dad5b26fdb52852adb82e3f8721
tajo-storage/src/main/java/org/apache/tajo/storage/FileScanner.java
c831822d04c5d37704aece0e7c0be2d347735c30
tajo-storage/src/main/java/org/apache/tajo/storage/LazyTuple.java
7878004d79e6da081d4618c129be62e77c732059
tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java
c3a7525154e0f36d51dcca211949f21f57a9f1c8
tajo-storage/src/main/java/org/apache/tajo/storage/RowFile.java
954eb54e66135bfc34fe28381cf619f53774390b
tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java
b0cb09dd6e3263a7e1576fa9360ad44b376ba661
tajo-storage/src/main/java/org/apache/tajo/storage/TableStatistics.java
41c9d610b11f71ceb3094d868cd5269150fa2072
tajo-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java
a6b87814b39d855bf599492933503dc04233c3fe
tajo-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniAppender.java
320946989e2a83e59498032f1e25f19b61e49b7a
tajo-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniScanner.java
2c2037f4cff5373900bf2e342cd93bed597b5375
tajo-storage/src/main/java/org/apache/tajo/storage/v2/CSVFileScanner.java
b93672bc47d66bc6925e0b0b1c6988adea957971
tajo-storage/src/main/java/org/apache/tajo/storage/v2/FileScannerV2.java
0d5b33d78a2ca6bbcf2241cc0025cd4dee92600b
tajo-storage/src/main/java/org/apache/tajo/storage/v2/RCFileScanner.java
a549a51e1e33484b263e21fb486c09133f433374
tajo-storage/src/test/java/org/apache/tajo/storage/TestLazyTuple.java
261852715f223f8c4756de30d2cc3c789bd7c987
tajo-storage/src/test/java/org/apache/tajo/storage/TestTupleComparator.java
7092953f6ea2b66330cf73c6bc54e72740aa01f6
tajo-storage/src/test/java/org/apache/tajo/storage/index/TestBSTIndex.java
34c362c099e6707cb7ccc1389ad8cb0979699c44
tajo-storage/src/test/java/org/apache/tajo/storage/index/TestSingleCSVFileBSTIndex.java
6d5d90f2c1955902f9579e18bfa3d21b93f5b93b
Diff: https://reviews.apache.org/r/18274/diff/
Testing (updated)
-------
mvn clean install
Thanks,
Hyunsik Choi
