----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18264/#review34973 -----------------------------------------------------------
Ship it! +1 for the patch. It looks good overall, and 'mvn clean install' finished successfully. And I recommend you to write a document for join options later on. - Jung JaeHwa On Feb. 19, 2014, 12:37 p.m., Hyunsik Choi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18264/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 12:37 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-609 > https://issues.apache.org/jira/browse/TAJO-609 > > > Repository: tajo > > > Description > ------- > > Currently, PlannerUtil::getRelationLineage ignores PartitionedTableScanNode. > As a result, PlannerUtil::getRelationLineage can return empty relations. It > results in wrong estimation of relation size. Finally, in the case where a > broadcast join between a partitioned table and a small table, this problem > causes the bug to choose the larger table instead of smaller one to be loaded > on hash table. > > This patch fixes this bug, refactors inner-join related methods, and added > more comments on them. > > > Diffs > ----- > > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java > 5583efdaf2f809d2cc47af13962d0a7c284924cc > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java > 624518b534a6214e2a2908e21ea977254b23368c > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/LocalTajoTestingUtility.java > ae59d11f8f43b67c03948aa5d0f9f5c63e971982 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestHashJoinExec.java > 48cd2655a5d09aedbed92ff6c15fa1cc07246d08 > > Diff: https://reviews.apache.org/r/18264/diff/ > > > Testing > ------- > > > Thanks, > > Hyunsik Choi > >
