-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18180/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 9:35 a.m.)
Review request for Tajo.
Changes
-------
Thanks JaeHwa, I upload a new patch referring to your reviews.
As you may know, however, in case that MySQL configured case insensitive, it
needs to handle table names with case insensitive. MySQL returns lower case
table name even it created by upper case.
Bugs: TAJO-594
https://issues.apache.org/jira/browse/TAJO-594
Repository: tajo
Description
-------
When I test MySQL catalog store instead of Derby, I get an error below. We have
to fix it.
{noformat}
2014-02-12 18:27:49,608 ERROR catalog.CatalogServer
(CatalogServer.java:addTable(255)) - Unknown column 'TID' in 'field list'
java.io.IOException: Unknown column 'TID' in 'field list
at
org.apache.tajo.catalog.store.AbstractDBStore.addTable(AbstractDBStore.java:326)
at
org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:253)
at
org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
at
org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
at
org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
at
org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:317)
at org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:280)
at org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
at
org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:158)
at
org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
{noformat}
Diffs (updated)
-----
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
8c2c0c3
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
b4bd605
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java
d78e734
Diff: https://reviews.apache.org/r/18180/diff/
Testing
-------
mvn clean install
environment
* Derby
* MySQL 5.6.10 with lower_case_table_names=1
Thanks,
Yongjun Park
