----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18414/#review35260 -----------------------------------------------------------
Ship it! +1 - Hyunsik Choi On Feb. 24, 2014, 4:54 p.m., Jung JaeHwa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18414/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 4:54 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-403 > https://issues.apache.org/jira/browse/TAJO-403 > > > Repository: tajo > > > Description > ------- > > If user write some function at 'group by' phase on hive query mode, it makes > a exception as follows: > tajo> set tajo.hive.query.mode=true; > tajo> select trim(name), count(1) from table1 group by trim(name); > Unexpected aggregation function. - signature:trim > It needs to support functions at 'group by' phase on hive query mode. > > > Diffs > ----- > > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java > 1228324 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java > dcdd862 > > tajo-core/tajo-core-backend/src/test/resources/queries/default/groupby_2.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/default/groupby_3.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/default/groupby_4.sql > PRE-CREATION > > tajo-core/tajo-core-backend/src/test/resources/queries/default/groupby_5.sql > PRE-CREATION > > Diff: https://reviews.apache.org/r/18414/diff/ > > > Testing > ------- > > mvn clean install > > > Thanks, > > Jung JaeHwa > >
