[
https://issues.apache.org/jira/browse/TAJO-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912512#comment-13912512
]
Tajo QA commented on TAJO-602:
------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12631109/TAJO-602.patch
against master revision 56fbd99.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:green}+1 tests included.{color} The patch appears to include 2 new
or modified test files.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:red}-1 findbugs.{color} The patch appears to introduce 183 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests.{color} The patch passed unit tests in
tajo-catalog/tajo-catalog-server tajo-common tajo-core/tajo-core-backend
tajo-rpc.
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/161//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/161//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/161//console
This message is automatically generated.
> WorkerResourceManager should be broke down into 3 parts
> --------------------------------------------------------
>
> Key: TAJO-602
> URL: https://issues.apache.org/jira/browse/TAJO-602
> Project: Tajo
> Issue Type: Sub-task
> Affects Versions: 1.0-incubating
> Reporter: Min Zhou
> Assignee: Hyunsik Choi
> Fix For: 1.0-incubating
>
> Attachments: TAJO-602.patch
>
>
> Before implementing a scheduler, I think we should do some refactoring at
> first. There are 2 interfaces and 4 classes related to resource management,
> they are WorkerResourceManager , YarnTajoResourceManager,
> TajoWorkerResourceManager reside in TajoMaster, and ResourceAllocator,
> YarnResourceAllocator, TajoResourceAllocator reside in QueryMasters.
> WorkerResourceManager actually plays 3 roles
> 1. Choose or start a QueryMaster for a query, and management it
> 2. allocate resource for query tasks / task runners (only for standalone mode)
> 3. Handle worker's heartbeat (only for standalone mode)
> If the scheduler is a decentralized one, like sparrow, we can allocate
> resource for a QueryMaster as the same way for a TaskRunner. So 1. and 2.
> can use the same interface, but called by 2 different caller. 3. is
> different from the others, we can create another service, let's say
> HeartbeatService to deal with worker's heartbeats.
> Any suggestion?
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
