[
https://issues.apache.org/jira/browse/TAJO-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13912528#comment-13912528
]
Tajo QA commented on TAJO-635:
------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12631142/TAJO-635.patch
against master revision 56fbd99.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:green}+1 tests included.{color} The patch appears to include 2 new
or modified test files.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:red}-1 findbugs.{color} The patch appears to introduce 185 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests.{color} The patch passed unit tests in
tajo-algebra tajo-core/tajo-core-backend.
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/162//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/162//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/162//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-algebra.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/162//console
This message is automatically generated.
> Improve tests of query semantic verification
> --------------------------------------------
>
> Key: TAJO-635
> URL: https://issues.apache.org/jira/browse/TAJO-635
> Project: Tajo
> Issue Type: Bug
> Affects Versions: 0.8-incubating, 1.0-incubating
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Attachments: TAJO-635.patch
>
>
> See TAJO-633. This is caused by some missed visitor functions. When I
> investigated TAJO-633, I found that there are more missed methods in
> BasicEvalNodeVisitor and EvalNodeVisitor2. Also, I found that
> ExprTestBase::testEval() does not use PreLogicalPlanVerifier,
> LogicalOptimizer, and LogicalPlanVerifier. As a result, query semantic
> verification has not been tested fully. This patch fixes all of them.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
