> On Feb. 27, 2014, 2:39 p.m., Jung JaeHwa wrote:
> > Hi, Hyunsik.
> >
> > It looks good overall to me.
> >
> > So, could you add more unit test cases for BetweenPredicateEval or
> > BinaryEval?
> >
> > for example:
> > testEval(schema, "table1", "123,234", "select col1 from table1 where col1
> > between '100' and '200'", new String[]{"123"});
> >
> > Cheers.
> >
> >
Thank you for the comment. Please take a look at TestPredicates::testBetween().
If you still think that it is insufficient, I'll add more tests.
- Hyunsik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18506/#review35600
-----------------------------------------------------------
On Feb. 26, 2014, noon, Hyunsik Choi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18506/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2014, noon)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-635
> https://issues.apache.org/jira/browse/TAJO-635
>
>
> Repository: tajo
>
>
> Description
> -------
>
> See TAJO-633. This is caused by some missed visitor functions. When I
> investigated TAJO-633, I found that there are more missed methods in
> BasicEvalNodeVisitor and EvalNodeVisitor2. Also, I found that
> ExprTestBase::testEval() does not use PreLogicalPlanVerifier,
> LogicalOptimizer, and LogicalPlanVerifier. As a result, query semantic
> verification has not been tested fully. This patch fixes all of them.
>
>
> Diffs
> -----
>
> CHANGES.txt 1d86479583502c65774ca727891b98756c654dfd
> tajo-algebra/src/main/java/org/apache/tajo/algebra/FunctionExpr.java
> 6635aeba2d862d317d1dce19ed4f5e68f699eb8b
>
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/BasicEvalNodeVisitor.java
> 6053469baa4bee78820c11a5e86f3bc5f39c822e
>
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/BetweenPredicateEval.java
> 61dc02bf4a7e130b5811176357657e37995bf5d8
>
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/EvalNodeVisitor2.java
> a77c9ea3e549eddd5fbf7ce8290da0b8495f3b3c
>
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
> 5e4c893266dc1b746612a20c83b62b761a6d31a5
>
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprsVerifier.java
> 2231df0f869669e8d84c2b5213caff9435fa650d
>
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
> 7e721c5781f0ce27d755771e18f6f6b5c21abade
>
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestSQLExpression.java
> 6520f9c0d171cf752429a7e866ab2cf3bbf52bb4
>
> Diff: https://reviews.apache.org/r/18506/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hyunsik Choi
>
>
