----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18557/#review35752 -----------------------------------------------------------
Ship it! +1. Push it. :) - Jung JaeHwa On Feb. 27, 2014, 3:12 a.m., Hyunsik Choi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18557/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 3:12 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-638 > https://issues.apache.org/jira/browse/TAJO-638 > > > Repository: tajo > > > Description > ------- > > I've attached the updated patch. In QueryUnitAttempt, the state machine > already deals with TA_UPDATE event at TA_ASSIGNED. So, this error must not be > incurred at that situation. I don't know the exact problem. I'll continue to > observe this problem. > > Regardless of the above issue, this report includes additional issue for > error handling. If QueryUnitAttempt faces such a situation, Query will be > hang. In order to eliminate the problem, in this patch, I've added some error > handling code to QueryUnitAttempt::handle. When a exception occurs in the > situation, it will abort the query without hanging. > > > Diffs > ----- > > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryUnitAttempt.java > aac5e37 > > Diff: https://reviews.apache.org/r/18557/diff/ > > > Testing > ------- > > mvn clean install > > > Thanks, > > Hyunsik Choi > >
