[ 
https://issues.apache.org/jira/browse/TAJO-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917994#comment-13917994
 ] 

Tajo QA commented on TAJO-645:
------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12632230/TAJO-645.patch
  against master revision 15c4576.

    {color:green}+1 @author.{color}  The patch does not contain any @author 
tags.

    {color:red}-1 tests included.{color}  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac.{color}  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the 
total number of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 183 new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in 
tajo-core/tajo-core-backend.

Test results: 
https://builds.apache.org/job/PreCommit-TAJO-Build/174//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-TAJO-Build/174//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/174//console

This message is automatically generated.

> Task.Reporter can cause NPE during reporting.
> ---------------------------------------------
>
>                 Key: TAJO-645
>                 URL: https://issues.apache.org/jira/browse/TAJO-645
>             Project: Tajo
>          Issue Type: Bug
>          Components: worker
>    Affects Versions: 0.8-incubating, 1.0-incubating
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>            Priority: Minor
>             Fix For: 0.8-incubating, 1.0-incubating
>
>         Attachments: TAJO-645.patch
>
>
> See the title. This problem causes the following error messages.
> {noformat}
> 014-03-03 19:52:27,680 ERROR worker.Task (Task.java:run(687)) - 
> java.lang.NullPointerException
>       at org.apache.tajo.worker.Task$Reporter$1.run(Task.java:681)
>       at java.lang.Thread.run(Thread.java:724)
> 2014-03-03 19:52:27,689 INFO  worker.Task (Task.java:<init>(181)) - Output 
> File Path: 
> hdfs://localhost:52744/tmp/tajo-hyunsik/staging/q_1393843945346_0001/RESULT/part-01-000000
> {noformat}
> The main cause is to start the report thread in Task before this.context is 
> initialized as follows:
> {code:java}
>     this.reporter = new Reporter(taskId, masterProxy);
>     this.reporter.startCommunicationThread();
>     ...
>     this.context = new TaskAttemptContext(systemConf, taskId,
>         request.getFragments().toArray(new 
> FragmentProto[request.getFragments().size()]), taskDir);
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to