-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18682/#review35958
-----------------------------------------------------------

Ship it!


+1
Great!!

- Jinho Kim


On March 3, 2014, 11:45 a.m., Hyunsik Choi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18682/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 11:45 a.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-645
>     https://issues.apache.org/jira/browse/TAJO-645
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> See the title. This problem causes the following error messages.
> {noformat}
> 014-03-03 19:52:27,680 ERROR worker.Task (Task.java:run(687)) - 
> java.lang.NullPointerException
>       at org.apache.tajo.worker.Task$Reporter$1.run(Task.java:681)
>       at java.lang.Thread.run(Thread.java:724)
> 2014-03-03 19:52:27,689 INFO  worker.Task (Task.java:<init>(181)) - Output 
> File Path: 
> hdfs://localhost:52744/tmp/tajo-hyunsik/staging/q_1393843945346_0001/RESULT/part-01-000000
> {noformat}
> 
> The main cause is to start the report thread in Task before this.context is 
> initialized as follows:
> 
> {code:java}
>     this.reporter = new Reporter(taskId, masterProxy);
>     this.reporter.startCommunicationThread();
>     ...
>     this.context = new TaskAttemptContext(systemConf, taskId,
>         request.getFragments().toArray(new 
> FragmentProto[request.getFragments().size()]), taskDir);
> {code}
> 
> 
> Diffs
> -----
> 
>   tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java 
> 56e539128094673bc07d92679fe0f0fbf81037f9 
> 
> Diff: https://reviews.apache.org/r/18682/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hyunsik Choi
> 
>

Reply via email to