----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18831/#review36344 -----------------------------------------------------------
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java <https://reviews.apache.org/r/18831/#comment67303> The main role of SQLAnalyzer is to parse SQL statements. If it contains verification codes, the verification codes will be likely to be disseminated throughout many classes. In order to put all verification into few classes, we have PreLogicalPlanVerifier and LogicalPlanVerifier, which are for tajo algebra expressions and LogicalPlan respectively. In this case, I suggest you to use PreLogicalPlanVerifier. I believe that it's the best place to put the verification. - Hyunsik Choi On March 6, 2014, 12:08 p.m., Jung JaeHwa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18831/ > ----------------------------------------------------------- > > (Updated March 6, 2014, 12:08 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-663 > https://issues.apache.org/jira/browse/TAJO-663 > > > Repository: tajo > > > Description > ------- > > RawFile must be used for Intermediate file. So users can't use TABLE's File > Format. Bellow statement expected fail but runs successfully. > create table orders_100_raw ( > o_orderkey INT8, > o_month text, > o_custkey INT8, > o_orderstatus TEXT, > o_totalprice FLOAT8, > o_orderdate TEXT, > o_orderpriority TEXT, > o_clerk TEXT, > o_shippriority INT4, > o_comment TEXT) > using RAW > > > Diffs > ----- > > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java > 29e4d43 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestSQLAnalyzer.java > 9462c75 > > tajo-core/tajo-core-backend/src/test/resources/queries/default/create_table_13.sql > PRE-CREATION > > Diff: https://reviews.apache.org/r/18831/diff/ > > > Testing > ------- > > mvn clean install > > > Thanks, > > Jung JaeHwa > >
