----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19170/#review37055 -----------------------------------------------------------
+1 Looks good to me. - Hyunsik Choi On March 13, 2014, 1:12 p.m., Jinho Kim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19170/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 1:12 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-651 > https://issues.apache.org/jira/browse/TAJO-651 > > > Repository: tajo > > > Description > ------- > > Currently, hcatalogstore does not use serde property in hive meta > {noformat} > # Storage Information > SerDe Library: org.apache.hadoop.hive.serde2.columnar.ColumnarSerDe > > InputFormat: org.apache.hadoop.hive.ql.io.RCFileInputFormat > OutputFormat: org.apache.hadoop.hive.ql.io.RCFileOutputFormat > Compressed: No > Num Buckets: -1 > Bucket Columns: [] > Sort Columns: [] > Storage Desc Params: > serialization.format 1 > {noformat} > > > Diffs > ----- > > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java > 0a40640d3fb838422eda21a8d2b1380a62d01f78 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableMeta.java > 50dc1484ff495e237953b5893574d31a2ebcf02c > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java > d61837537b32d8a33f71c81dd007192e166af881 > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java > 0f0ea0495a9ef9030c68eccfb19af10d17af57ed > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java > f2764fbe985166e8eb0c35a944c98fe516f6d842 > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java > 3cf2302a05818ab2ee64c343103a4db372e82fc8 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/benchmark/TPCH.java > 5e9c9d3ac1d7a5eda5e71821eb1836dc24514f9c > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java > af7c3e926d97e299f7360c6708261048559a6aa2 > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TpchTestBase.java > 78c5c094ca359fd7ff185c67880f5442d3e2faf0 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestDDLBuilder.java > 0594a2f47a09f4aadf784b0ae8286c06a148408b > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNullValues.java > b0778d4e29b1b2f47957e06ba6c72b2a6b8edcbb > tajo-core/tajo-core-backend/src/test/resources/results/testBuildDDL.result > 1ca6351c433a0ccc58d42ad1b490069584f07857 > tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java > cf1ccc03f66a6bcfe88d39ac64e43b86378726da > tajo-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java > 07f4c8e17459c9ff64ba9d696c44d32fc840b3bc > tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java > 3743c4defdeb002ccf4da189b6ce5b188cb05b24 > > Diff: https://reviews.apache.org/r/19170/diff/ > > > Testing > ------- > > mvn clean install -Phcatalog-0.12.0 > Hive-0.12.0 CLI > > > Thanks, > > Jinho Kim > >
