----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19169/#review37152 -----------------------------------------------------------
+1 This feature is necessary. The patch is looks good to me, and it includes necessary unit tests. Thank you for your contribution. - Hyunsik Choi On March 13, 2014, 10:09 p.m., Ilhyun Suh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19169/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 10:09 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-553 > https://issues.apache.org/jira/browse/TAJO-553 > > > Repository: tajo > > > Description > ------- > > The current TajoClient only provides a method for retrieving lists of running > queries. However, users may want to see the queries which are already > finished, failed or even not started. (some queries are not started > immediately after TAJO-540.) > > I have added getFinishedQueryList method in TajoClient and renamed > getQueryList method to getRunningQueryList in TajoClient. > I have also added test method for getFinishedQueryList in TestTajoClient > > > Diffs > ----- > > tajo-client/src/main/java/org/apache/tajo/client/TajoAdmin.java e6fe88f > tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java 7ee4694 > tajo-client/src/main/proto/TajoMasterClientProtocol.proto 9feecdb > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java > 60f705f > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestTajoClient.java > ee03bd6 > > Diff: https://reviews.apache.org/r/19169/diff/ > > > Testing > ------- > > passed mvn verify > > > File Attachments > ---------------- > > TAJO-553.patch > > https://reviews.apache.org/media/uploaded/files/2014/03/13/18a3fb2d-b005-4fb1-a9e1-c1c1eb77bac3__TAJO-553.patch > > > Thanks, > > Ilhyun Suh > >
