----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19221/#review37682 -----------------------------------------------------------
Ship it! +1. This patch looks good to me. - Jihoon Son On March 17, 2014, 8:41 p.m., Dae Myung Kang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19221/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 8:41 p.m.) > > > Review request for Tajo. > > > Bugs: https://issues.apache.org/jira/browse/TAJO-687 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/TAJO-687 > > > Repository: tajo > > > Description > ------- > > > TajoMaster currently doesn't pass tajoConf to create catalogServer. so it > create RpcConnectionPool with null tajoConf. > > so it can cause NullPointerException if you use tajo conf in NettyClientBase > > > Diffs > ----- > > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LocalCatalogWrapper.java > eb062fd > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java > c42b0f3 > > Diff: https://reviews.apache.org/r/19221/diff/ > > > Testing > ------- > > pass "mvn clean install" > > > Thanks, > > Dae Myung Kang > >
