-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18847/
-----------------------------------------------------------

(Updated March 19, 2014, 5:24 p.m.)


Review request for Tajo.


Changes
-------

I applied reviews


Bugs: https://issues.apache.org/jira/browse/TAJO-623
    
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/TAJO-623


Repository: tajo


Description
-------

Currently, to chnage network buffer size or tcp_nodelay, or keepalive options, 
we should change source code.

```c
<property>
<name>tajo.network.receivebuffersize</name>
<value>10485760</value>
</property>
```

NETWORK_REUSEADDRESS("tajo.network.reuseaddress", true)
NETWORK_TCP_NODELAY("tajo.network.tcpnodelay", true)
NETWORK_KEEP_ALIVE("tajo.network.keepalive", true)
NETWORK_CONNECT_TIMEOUT_MILLIS("tajo.network.connecttimeoutmillis", 10000)
NETWORK_CONNECT_RESPONSE_TIMEOUT_MILLIS("tajo.network.connectresponsetimeoutmillis",
 10000)
NETWORK_RECEIVE_BUFFERSIZE("tajo.network.receivebuffersize", 1048576 * 10)


Diffs (updated)
-----

  
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
 621b475 
  tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java 3ca17a0 
  tajo-common/src/test/java/org/apache/tajo/conf/TestTajoConf.java PRE-CREATION 
  tajo-common/src/test/resources/tajo-rpc.xml PRE-CREATION 
  
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
 dc70f23 
  
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterService.java
 5e9f729 
  
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterManagerService.java
 e3e0260 
  
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/rm/TajoResourceTracker.java
 1bcf38b 
  
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoWorkerClientService.java
 a73623f 
  
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoWorkerManagerService.java
 392a7cf 
  tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcClient.java c84d6b6 
  tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java b7e3cb6 
  tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcClient.java 604ed52 
  tajo-rpc/src/main/java/org/apache/tajo/rpc/BlockingRpcServer.java 067d824 
  tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyClientBase.java 8373c37 
  tajo-rpc/src/main/java/org/apache/tajo/rpc/ProtoPipelineFactory.java b2a2004 
  tajo-rpc/src/main/java/org/apache/tajo/rpc/RpcConnectionPool.java 777281f 
  tajo-rpc/src/test/java/org/apache/tajo/rpc/TestAsyncRpc.java 97bc28d 
  tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java dedd96e 

Diff: https://reviews.apache.org/r/18847/diff/


Testing
-------

Passed: mvn clean install
Passed: add unittest to check tajoconf


Thanks,

Dae Myung Kang

Reply via email to