[
https://issues.apache.org/jira/browse/TAJO-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942648#comment-13942648
]
Hyunsik Choi commented on TAJO-377:
-----------------------------------
I'm sorry for late review. The patch looks good to me.
There is one suggestion. StringBuffer is synchronized, but StringBuilder is
not. This function is not invoked concurrently. Consequently, StringBuffer will
cause some unnecessary overheads while processing lots of rows. Could you
replace StringBuffer with StringBuilder? Then, I'll review it quickly.
> Implement concat function
> -------------------------
>
> Key: TAJO-377
> URL: https://issues.apache.org/jira/browse/TAJO-377
> Project: Tajo
> Issue Type: New Feature
> Components: function/udf
> Affects Versions: 0.8-incubating
> Reporter: Seungun Choe
> Assignee: Seungun Choe
> Priority: Minor
> Fix For: 0.8-incubating
>
> Attachments: TAJO-377.patch, TAJO-377_1.patch, TAJO-377_2.patch,
> TAJO-377_3.patch, TAJO-377_4.patch
>
>
> Plz assign to me. :)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
